Commit to client's node id in bLIP-52/LSPS2 promise #4040
Merged
+109
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the promise HMAC would only commit to the promise secret and the `OpeningFeeParams` fields, leaving room for other clients to reuse the same `OpeningFeeParams` in `BuyRequests` if they'd acquire it somehow out-of-bounds. While this flexibility also has some benefits, we here have the service commit to the client's node id, making sure only the original client can redeem a specific `OpeningFeeParams`.
|
👋 Thanks for assigning @TheBlueMatt as a reviewer! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4040 +/- ##
==========================================
+ Coverage 88.73% 88.75% +0.01%
==========================================
Files 176 176
Lines 129015 129106 +91
Branches 129015 129106 +91
==========================================
+ Hits 114485 114583 +98
+ Misses 11935 11923 -12
- Partials 2595 2600 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TheBlueMatt
approved these changes
Sep 2, 2025
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
|
post merge ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4037.
Previously, the promise HMAC would only commit to the promise secret and the
OpeningFeeParamsfields, leaving room for other clients to reuse the sameOpeningFeeParamsinBuyRequestsif they'd acquire it somehow out-of-bounds.While this flexibility also has some benefits, we here have the service commit to the client's node id, making sure only the original client can redeem a specific
OpeningFeeParams.(cc @johncantrell97 @martinsaposnic)