Don't auto-fail offers payments pre-HTLC lock in #4078
Conversation
Previously, we had a bug that particularly affected async payments where if an
outbound payment was in the state {Static}InvoiceReceived and there was a call
to process_pending_htlc_forwards, the payment would be automatically abandoned.
We would behave correctly and avoid abandoning if the payment was awaiting an
invoice, but not if the payment had an invoice but the HTLCs weren't yet locked
in.
|
👋 Thanks for assigning @joostjager as a reviewer! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4078 +/- ##
==========================================
+ Coverage 88.63% 88.64% +0.01%
==========================================
Files 176 176
Lines 131920 131922 +2
Branches 131920 131922 +2
==========================================
+ Hits 116927 116948 +21
+ Misses 12325 12311 -14
+ Partials 2668 2663 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| match self { | ||
| PendingOutboundPayment::AwaitingInvoice { .. } => true, | ||
| PendingOutboundPayment::AwaitingInvoice { .. } | ||
| | PendingOutboundPayment::InvoiceReceived { .. } |
There was a problem hiding this comment.
First I thought InvoiceReceived isn't necessary, because the payment is initiated immediately after receiving the invoice. But on a closer look, I think there are also similar gaps that require this check. There is also manual bolt12 invoice payment. No test coverage though I think.
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
|
Backported in #4143 |
5 participants
Previously, we had a bug that particularly affected async payments where if an outbound payment was in the state
{Static}InvoiceReceivedand there was a call toprocess_pending_htlc_forwards, the payment would be automatically abandoned. We would behave correctly and avoid abandoning if the payment was awaiting an invoice, but not if the payment had an invoice but the HTLCs weren't yet locked in.