Skip to content

Conversation

wpaulino
Copy link
Contributor

As our splice implementation is not yet complete (missing RBF support) and we still need to do cross-compatibility testing with eclair/CLN, we signal the agreed upon prototype feature bit instead.

Fixes #4062.

As our splice implementation is not yet complete (missing RBF support)
and we still need to do cross-compatibility testing with eclair/CLN, we
signal the agreed upon prototype feature bit instead.
@wpaulino wpaulino added this to the 0.2 milestone Oct 10, 2025
@wpaulino wpaulino requested a review from TheBlueMatt October 10, 2025 18:24
@wpaulino wpaulino self-assigned this Oct 10, 2025
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Oct 10, 2025

👋 Thanks for assigning @TheBlueMatt as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

TheBlueMatt
TheBlueMatt previously approved these changes Oct 10, 2025
Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial enough, landing.

@ldk-reviews-bot
Copy link

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

@TheBlueMatt
Copy link
Collaborator

Oops, ln::msgs::tests::encoding_commitment_signed needs updating for the new tlv

Now that we are sure we will be moving forward with the `funding_txid`
TLV, we use the TLV type as mandated per the spec.
@TheBlueMatt TheBlueMatt merged commit 21e9a9c into lightningdevkit:main Oct 10, 2025
22 checks passed
@wpaulino wpaulino deleted the splice-prototype-feature-bit branch October 10, 2025 21:23
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.75%. Comparing base (fcb1164) to head (bddd5c7).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4156   +/-   ##
=======================================
  Coverage   88.74%   88.75%           
=======================================
  Files         180      180           
  Lines      135809   135821   +12     
  Branches   135809   135821   +12     
=======================================
+ Hits       120523   120546   +23     
+ Misses      12519    12506   -13     
- Partials     2767     2769    +2     
Flag Coverage Δ
fuzzing 21.71% <ø> (+0.01%) ⬆️
tests 88.59% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use temp feature bits for splicing and 0FC

3 participants