-
Notifications
You must be signed in to change notification settings - Fork 421
Signal splice prototype feature bit instead #4156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signal splice prototype feature bit instead #4156
Conversation
As our splice implementation is not yet complete (missing RBF support) and we still need to do cross-compatibility testing with eclair/CLN, we signal the agreed upon prototype feature bit instead.
👋 Thanks for assigning @TheBlueMatt as a reviewer! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trivial enough, landing.
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
Oops, |
Now that we are sure we will be moving forward with the `funding_txid` TLV, we use the TLV type as mandated per the spec.
88368df
to
bddd5c7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4156 +/- ##
=======================================
Coverage 88.74% 88.75%
=======================================
Files 180 180
Lines 135809 135821 +12
Branches 135809 135821 +12
=======================================
+ Hits 120523 120546 +23
+ Misses 12519 12506 -13
- Partials 2767 2769 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
As our splice implementation is not yet complete (missing RBF support) and we still need to do cross-compatibility testing with eclair/CLN, we signal the agreed upon prototype feature bit instead.
Fixes #4062.