Skip to content

Conversation

TheBlueMatt
Copy link
Collaborator

While its somewhat sad to do, we didn't really make the progress we wanted on dual funded channels in 0.2, and thus aren't super confident in them. Further, because we still don't support actually contributing inputs to an inbound channel nor outbound v2 channel opens there's not really any reason to support them.

Thus, we simply re-cfg-gate them here for 0.2.

@TheBlueMatt TheBlueMatt added this to the 0.2 milestone Oct 10, 2025
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Oct 10, 2025

👋 I see @tankyleo was un-assigned.
If you'd like another reviewer assignment, please click here.

Copy link

codecov bot commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 53.84615% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.80%. Comparing base (21e9a9c) to head (ac8aa68).

Files with missing lines Patch % Lines
lightning/src/util/config.rs 53.84% 0 Missing and 12 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              0.2    #4157   +/-   ##
=======================================
  Coverage   88.79%   88.80%           
=======================================
  Files         180      180           
  Lines      136553   136566   +13     
  Branches   136553   136566   +13     
=======================================
+ Hits       121259   121277   +18     
  Misses      12494    12494           
+ Partials     2800     2795    -5     
Flag Coverage Δ
fuzzing 21.63% <53.84%> (+0.02%) ⬆️
tests 88.64% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tankyleo tankyleo removed their request for review October 10, 2025 22:07
While its somewhat sad to do, we didn't really make the progress we
wanted on dual funded channels in 0.2, and thus aren't super
confident in them. Further, because we still don't support actually
contributing inputs to an inbound channel nor outbound v2 channel
opens there's not really any reason to support them.

Thus, we simply re-cfg-gate them here for 0.2.
@TheBlueMatt TheBlueMatt force-pushed the 2025-10-0.2-no-v2-opens branch from f6d8c0e to ac8aa68 Compare October 10, 2025 22:25
@TheBlueMatt
Copy link
Collaborator Author

Grrr, my attempt at cfg-flagging the config read so that the fuzzer doesn't change didn't work cause rustc invented a type out of thin air rather than failing...I set it to u8 so it works now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants