Skip to content

Reduce Boxing using impl Trait in trait methods post-MSRV-bump #4175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tnull merged 6 commits into from
Dec 8, 2025

Drop `Box`ing of iterators during BOLT 11 invoice serialization

b1f1ee2
Select commit
Loading
Failed to load commit list.
Merged

Reduce Boxing using impl Trait in trait methods post-MSRV-bump #4175

Drop `Box`ing of iterators during BOLT 11 invoice serialization
b1f1ee2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 10, 2025 in 1s

89.32% (-0.01%) compared to e42e74e

View this Pull Request on Codecov

89.32% (-0.01%) compared to e42e74e

Details

Codecov Report

❌ Patch coverage is 73.94636% with 68 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.32%. Comparing base (e42e74e) to head (b1f1ee2).

Files with missing lines Patch % Lines
lightning-background-processor/src/lib.rs 0.00% 20 Missing ⚠️
lightning-block-sync/src/rest.rs 27.77% 13 Missing ⚠️
lightning-block-sync/src/rpc.rs 27.77% 13 Missing ⚠️
lightning-block-sync/src/gossip.rs 0.00% 9 Missing ⚠️
lightning/src/util/test_utils.rs 25.00% 6 Missing ⚠️
lightning-persister/src/fs_store.rs 90.90% 4 Missing ⚠️
lightning-net-tokio/src/lib.rs 60.00% 2 Missing ⚠️
lightning-liquidity/src/lsps2/service.rs 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4175      +/-   ##
==========================================
- Coverage   89.33%   89.32%   -0.01%     
==========================================
  Files         180      180              
  Lines      138055   138076      +21     
  Branches   138055   138076      +21     
==========================================
+ Hits       123326   123333       +7     
- Misses      12122    12141      +19     
+ Partials     2607     2602       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov