Expose process_pending_update_add_htlcs in tests#4240
Merged
TheBlueMatt merged 1 commit intolightningdevkit:0.2from Nov 21, 2025
Merged
Conversation
Useful for upgrade/downgrade testing in the lightning-tests module, which cannot access internal methods.
|
👋 I see @jkczyz was un-assigned. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 0.2 #4240 +/- ##
=======================================
Coverage 88.87% 88.87%
=======================================
Files 180 180
Lines 138000 138003 +3
Branches 138000 138003 +3
=======================================
+ Hits 122642 122650 +8
- Misses 12534 12540 +6
+ Partials 2824 2813 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Doesn't need backport label cause this was on the 0.2 branch directly. @valentinewallace would you mind doing the same thing on the main branch just because? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful for upgrade/downgrade testing in the
lightning-testsmodule, which cannot accesslightning-internal methods.Backported to 0.2 for testing on 0.3