Skip to content

Follow-ups to #4227 (Part 2) #4303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
valentinewallace wants to merge 14 commits into
base: main
Choose a base branch
from
+545 −601
Open

Follow-ups to #4227 (Part 2) #4303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7c97f3c
Remove unnecessary update_add clone on Channel ser
valentinewallace Dec 16, 2025
8204e0a
Move is_chan_closed check into loop
valentinewallace Jan 5, 2026
f0317b8
Don't double-forward HTLCs in rebuilt update_adds map
valentinewallace Dec 12, 2025
31b8d54
Optimize dedup_decode_update_add_htlcs
valentinewallace Dec 16, 2025
f245139
Prefer legacy forward maps on manager read
valentinewallace Dec 16, 2025
cd8007c
Trivial: document some fields on MonitorRestoreUpdates
valentinewallace Jan 5, 2026
5cf8d3d
Prune inbound HTLC onions once forwarded
valentinewallace Jan 5, 2026
11b3f12
Pass logger into FundedChannel::read
valentinewallace Jan 6, 2026
16d4bbd
Remove deprecated InboundHTLCResolution::Resolved variant
valentinewallace Jan 6, 2026
4bb08cc
Remove now-unused param from monitor_updating_paused
valentinewallace Jan 6, 2026
37e57dd
Simplify InboundHTLCStates' htlc resolution type
valentinewallace Jan 6, 2026
cc57595
Delete now-unused ChannelContext::monitor_pending_forwards
valentinewallace Jan 6, 2026
7f5b830
Delete now-unused MonitorRestoreUpdates::accepted_htlcs
valentinewallace Jan 6, 2026
e2ea1ed
Delete now-unused PendingHTLCStatus
valentinewallace Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,12 @@ welcomed.

* `LDK_TEST_DETERMINISTIC_HASHES` - When set to `1`, uses deterministic hash map iteration order in tests. This ensures consistent test output across runs, useful for comparing logs before and after changes.

* `LDK_TEST_REBUILD_MGR_FROM_MONITORS` - If set to `1`, on test node reload the `ChannelManager`'s
HTLC set will be reconstructed from `Channel{Monitor}` persisted data. If `0`, test nodes will be
reloaded from persisted `ChannelManager` data using legacy code paths. This ensures consistent
test output across runs, useful for comparing logs before and after changes, since otherwise the
selection of which codepaths to be used on reload will be chosen randomly.

C/C++ Bindings
--------------

Expand Down
Loading
Loading