Skip to content

Add default implementation for tracking metadata #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from
Closed

Add default implementation for tracking metadata #636

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
e76ac4e
Add default implementation for tracking metadata
sourabhmarathe Jun 7, 2020
42f7d56
Track failed portion of MPP, not entire MPP
sourabhmarathe Jun 8, 2020
a424c63
Remove failed route tracking methods
sourabhmarathe Jun 8, 2020
51c8d1b
Remove functions that would never be called
sourabhmarathe Jun 8, 2020
1a1dc96
Return u64::MAX if chan is on failed list
sourabhmarathe Jun 8, 2020
4664e99
Change output of get_channel_fee_penalty
sourabhmarathe Jun 12, 2020
37c6de6
Add failed_route()
sourabhmarathe Jun 12, 2020
4397c0e
Add RoutingFeePenalty param to get_route
sourabhmarathe Jun 12, 2020
84b7f6b
Add fee penalty to htlc minimum in get_route()
sourabhmarathe Jun 14, 2020
33deb1f
Do not add route to failed list on success
sourabhmarathe Jun 17, 2020
5e229fc
Move penalty fee check to correct place in code
sourabhmarathe Jun 17, 2020
6beca99
Address ariard review
sourabhmarathe Jun 24, 2020
9e7e2f6
Add constructor for DefaultMetadata
sourabhmarathe Jun 24, 2020
7529726
Add DefaultMetadata param to get_route calls
sourabhmarathe Jun 24, 2020
8dd338c
Use checked_add when calculating new_fee in get_route()
sourabhmarathe Jun 25, 2020
bb5c725
Remove channel from failed channels on success
sourabhmarathe Jun 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lightning/src/routing/network_graph.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ impl RouteFeePenalty for DefaultMetadata {
if self.failed_channels.get(&chan_id) == None {
return 0;
} else {
return u64::MAX;
return u64::max_value();
}
}

Expand Down
4 changes: 2 additions & 2 deletions lightning/src/routing/router.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ use chain::chaininterface::ChainWatchInterface;
use ln::channelmanager;
use ln::features::{ChannelFeatures, NodeFeatures};
use ln::msgs::{DecodeError,ErrorAction,LightningError};
use routing::network_graph::{NetGraphMsgHandler, RoutingFees};
use routing::network_graph::{NetGraphMsgHandler, RoutingFees, RouteFeePenalty};
use util::ser::{Writeable, Readable};
use util::logger::Logger;

Expand Down Expand Up @@ -162,7 +162,7 @@ struct DummyDirectionalChannelInfo {
/// equal), however the enabled/disabled bit on such channels as well as the htlc_minimum_msat
/// *is* checked as they may change based on the receiving node.
pub fn get_route<C: Deref, L: Deref>(our_node_id: &PublicKey, net_graph_msg_handler: &NetGraphMsgHandler<C, L>, target: &PublicKey, first_hops: Option<&[channelmanager::ChannelDetails]>,
last_hops: &[RouteHint], final_value_msat: u64, final_cltv: u32, logger: L) -> Result<Route, LightningError> where C::Target: ChainWatchInterface, L::Target: Logger {
last_hops: &[RouteHint], final_value_msat: u64, final_cltv: u32, logger: L, net_metadata: impl RouteFeePenalty) -> Result<Route, LightningError> where C::Target: ChainWatchInterface, L::Target: Logger {
// TODO: Obviously *only* using total fee cost sucks. We should consider weighting by
// uptime/success in using a node in the past.
if *target == *our_node_id {
Expand Down