Rename vss-client crate to vss-client-ng
#46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for assigning @tnull as a reviewer! |
tankyleo
force-pushed
the
crate-rename
branch
from
9d3715a to
d8086d0
Compare
tnull
reviewed
Nov 5, 2025
| @@ -1,8 +1,8 @@ | |||
| [package] | |||
| name = "vss-client" | |||
| name = "vss-client-ng" | |||
Contributor
There was a problem hiding this comment.
While we're here, mind tacking-on a second commit adding an authors field so people can see who are the primary contacts for the crate? I propose:
authors = ["Leo Nash <[email protected]>", "Elias Rohrer <[email protected]>"]
Cargo.toml
Outdated
| license = "MIT OR Apache-2.0" | ||
| edition = "2021" | ||
| homepage = "https://lightningdevkit.org/" | ||
| repository = "https://github.com/lightningdevkit/vss-rust-client" |
Contributor
There was a problem hiding this comment.
Should we reflect the change/repo rename to rust-vss-client here?
| @@ -1,8 +1,8 @@ | |||
| [package] | |||
| name = "vss-client" | |||
| name = "vss-client-ng" | |||
Contributor
There was a problem hiding this comment.
Might also want to make this change in the header of README.md, which should probably be named after the crate, not the repo.
Use the new crate name in `README.md`, not the repo name. Update the repository link in preparation for repo move.
tankyleo
force-pushed
the
crate-rename
branch
from
d8086d0 to
36ac919
Compare
tnull
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.