Add JWTAuthorizer Implementation. #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkczyz
reviewed
Oct 22, 2024
| private final PublicKey publicKey; | ||
| private final JWTVerifier verifier; | ||
|
|
||
| public JwtAuthorizer(String pemFormatPublicKey) throws Exception { |
Contributor
There was a problem hiding this comment.
Consider linking to the RFC or other resource on what PEM format is.
Contributor
Author
There was a problem hiding this comment.
On some searching afaiu, there are multiple RFCs to specify that format but not a single one.
To avoid any further confusions, I gave a reference to OpenSSL docs and way to generate key pairs.
G8XSU
force-pushed
the
java-jwt-authorizer
branch
from
bd1a14c to
4d5cbd5
Compare
Contributor
Author
|
Addressed comments, squashed fixups. |
jkczyz
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.