-
Notifications
You must be signed in to change notification settings - Fork 19
build: upgrade jooq and add junit platform #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: upgrade jooq and add junit platform #50
Conversation
With the release of Gradle 9.0.0, we experienced build failures due to deprecated access to plugin conventions (JavaPluginConvention). Ref: https://docs.gradle.org/9.0.0-rc-1/userguide/upgrading_version_8.html#deprecated_access_to_conventions To address this, we: 1. Upgrade jOOQ Gradle plugin from 8.0 to 8.2.2 to avoid deprecation warnings when using Gradle 9.0. Ref: https://github.com/etiennestuder/gradle-jooq-plugin/releases/tag/v8.2.2 2. Upgrade jOOQ from 3.17.7 to 3.19.1 to match the plugin version upgrade. Note: We avoid the latest version of jOOQ because it requires Java 21.
Additionally, we add JUnit Platform Launcher which is required for JUnit 5 tests in newer Gradle versions.
|
👋 Thanks for assigning @jkczyz as a reviewer! |
update to Gradle 9.0 and auto-extract version number.
7756794 to
f31eeed
Compare
| # Print Info | ||
| java -version | ||
| gradle --version | ||
| GRADLE_VERSION=$(gradle --version | awk '/^Gradle/ {print $2}' | head -1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of using hard-coded Gradle versions, we extract the version number from the current release.
|
🔔 1st Reminder Hey @wpaulino! This PR has been waiting for your review. |
tnull
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
|
@enigbe The changes make sense to me, but AFAICT the CI over at enigbe/ldk-node#5 still fails due to expecting Gradle 10? Do we need to fix this here or over on the LDK Node side? |
As is, it is meant to fail until these changes go in. |
What this PR does
With the release of Gradle
9.0.0, we experienced buildfailures due to deprecated access to plugin conventions
(JavaPluginConvention).
Ref: Gradle
9.0releaseTo address this, we:
8.0to8.2.2toavoid deprecation warnings when using Gradle
9.0.Ref: jOOQ plugin release
3.17.7to3.19.1to match theplugin version upgrade.
Note: We avoid the latest version of jOOQ because it
requires Java 21.
Additionally, we add JUnit Platform Launcher which
is required for JUnit 5 tests in newer Gradle versions.
Related Issues
cc @tnull