Skip to content

Conversation

@enigbe
Copy link
Contributor

@enigbe enigbe commented Jul 3, 2025

What this PR does

With the release of Gradle 9.0.0, we experienced build
failures due to deprecated access to plugin conventions
(JavaPluginConvention).
Ref: Gradle 9.0 release

To address this, we:

  • Upgrade jOOQ Gradle plugin from 8.0 to 8.2.2 to
    avoid deprecation warnings when using Gradle 9.0.
    Ref: jOOQ plugin release
  • Upgrade jOOQ from 3.17.7 to 3.19.1 to match the
    plugin version upgrade.

Note: We avoid the latest version of jOOQ because it
requires Java 21.

Additionally, we add JUnit Platform Launcher which
is required for JUnit 5 tests in newer Gradle versions.

Related Issues

  • LDK-Node Issue #581

cc @tnull

enigbe added 2 commits July 3, 2025 20:45
With the release of Gradle 9.0.0, we experienced build
failures due to deprecated access to plugin conventions
(JavaPluginConvention).
Ref: https://docs.gradle.org/9.0.0-rc-1/userguide/upgrading_version_8.html#deprecated_access_to_conventions

To address this, we:
1. Upgrade jOOQ Gradle plugin from 8.0 to 8.2.2 to
avoid deprecation warnings when using Gradle 9.0.
Ref: https://github.com/etiennestuder/gradle-jooq-plugin/releases/tag/v8.2.2

2. Upgrade jOOQ from 3.17.7 to 3.19.1 to match the
plugin version upgrade.

Note: We avoid the latest version of jOOQ because it
requires Java 21.
Additionally, we add JUnit Platform Launcher which
is required for JUnit 5 tests in newer Gradle versions.
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Jul 3, 2025

👋 Thanks for assigning @jkczyz as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@ldk-reviews-bot ldk-reviews-bot requested a review from wpaulino July 3, 2025 20:31
update to Gradle 9.0 and auto-extract version
number.
@enigbe enigbe force-pushed the 2025-07-upgrade-jooq-and-add-junit-platform branch from 7756794 to f31eeed Compare July 3, 2025 21:10
# Print Info
java -version
gradle --version
GRADLE_VERSION=$(gradle --version | awk '/^Gradle/ {print $2}' | head -1)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using hard-coded Gradle versions, we extract the version number from the current release.

@ldk-reviews-bot
Copy link

🔔 1st Reminder

Hey @wpaulino! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@tnull
Copy link
Contributor

tnull commented Jul 7, 2025

@enigbe The changes make sense to me, but AFAICT the CI over at enigbe/ldk-node#5 still fails due to expecting Gradle 10? Do we need to fix this here or over on the LDK Node side?

@jkczyz jkczyz requested review from jkczyz and removed request for wpaulino July 7, 2025 14:48
@enigbe
Copy link
Contributor Author

enigbe commented Jul 7, 2025

The changes make sense to me, but AFAICT the CI over at enigbe/ldk-node#5 still fails due to expecting Gradle 10? Do we need to fix this here or over on the LDK Node side?

As is, it is meant to fail until these changes go in.
The fix is on LDK-Node because it is still checking out vss-server with Gradle 8 hard-coded. Here is the passing CI test after introducing commit 430275a that checks out these changes from my fork. Once these changes go in, I can upstream the PR.

@jkczyz jkczyz merged commit 02ed8e5 into lightningdevkit:main Jul 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants