Use Rust server in CI and add LDK Node integration tests #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for assigning @tankyleo as a reviewer! |
.. especially given that there is a new non-forwards-compatible version.
tnull
force-pushed
the
2025-10-use-rust-in-CI
branch
from
d9c0e90 to
9b2ef38
Compare
Contributor
Author
|
Integration test breakage is currently on the LDK Node side, will be fixed by lightningdevkit/ldk-node#670 |
tnull
force-pushed
the
2025-10-use-rust-in-CI
branch
from
9b2ef38 to
8ebd049
Compare
Contributor
Author
|
Should be resolved, kicked CI. |
tankyleo
reviewed
Oct 29, 2025
Contributor
tankyleo
left a comment
tankyleo
left a comment
There was a problem hiding this comment.
Mostly LGTM, some minor comments / questions.
Reproduced the Cargo.lock update on my machine.
Contributor
|
And thank you for doing this ! |
tnull
force-pushed
the
2025-10-use-rust-in-CI
branch
from
8ebd049 to
cdab1d1
Compare
Contributor
Author
|
Addressed pending feedback. Force-pushed with the following changes: > git diff-tree -U2 8ebd049 ba2e6c5
diff --git a/.github/workflows/build-and-deploy-rust.yml b/.github/workflows/build-and-deploy-rust.yml
index 7a2185b..52dc188 100644
--- a/.github/workflows/build-and-deploy-rust.yml
+++ b/.github/workflows/build-and-deploy-rust.yml
@@ -38,5 +38,4 @@ jobs:
- name: Hit endpoint to verify service is up
run: |
- # Wait for tomcat-startup
sleep 5 |
tnull
force-pushed
the
2025-10-use-rust-in-CI
branch
from
cdab1d1 to
ba2e6c5
Compare
tankyleo
reviewed
Oct 30, 2025
While we already have VSS integration tests on the LDK Node side, we here also run them here to ensure any *server* changes do not result in test failures.
tnull
force-pushed
the
2025-10-use-rust-in-CI
branch
from
ba2e6c5 to
e415f32
Compare
Contributor
Author
|
Now force-pushed with the following changes: diff --git a/.github/workflows/build-and-deploy-rust.yml b/.github/workflows/build-and-deploy-rust.yml
index 52dc188..af92d17 100644
--- a/.github/workflows/build-and-deploy-rust.yml
+++ b/.github/workflows/build-and-deploy-rust.yml
@@ -13,5 +13,5 @@ jobs:
services:
postgres:
- image: postgres:15
+ image: postgres:latest
ports:
- 5432:5432 |
tankyleo
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we now officially deprecated the Java version, we never switched our CI to use the Rust version.
Moreover, we add LDK Node integration tests to CI. This ensures any changes on the server side don't cause any integration test failures.