Skip to content

Conversation

@jamaljsr
Copy link
Member

I noticed the daily CI deployment is failing due to a recent change in the loop repo. I was able to reproduce the issue locally by running ./generate.sh.

 Installing loop and loopd.
GO111MODULE=on go install -v -tags="" -ldflags "-X github.com/lightninglabs/loop.Commit=v0.28.9-beta-23-g2ec44f0c83a22756c7c20eeea94fe18e25386831" github.com/lightninglabs/loop/cmd/loop
GO111MODULE=on go install -v -tags="" -ldflags "-X github.com/lightninglabs/loop.Commit=v0.28.9-beta-23-g2ec44f0c83a22756c7c20eeea94fe18e25386831" github.com/lightninglabs/loop/cmd/loopd
~/dev/lightninglabs/lightning-api-ng
~/dev/lightninglabs/lightning-api-ng/build/protos/loop ~/dev/lightninglabs/lightning-api-ng
server.proto: File not found.
swapserverrpc/staticaddr.proto:2:1: Import "server.proto" was not found or had errors.
swapserverrpc/staticaddr.proto:72:14: "PrevoutInfo" is not defined.

This small change resolves the proto compilation error and will fix the CI deployment.

@jamaljsr jamaljsr self-assigned this Dec 14, 2024
@jamaljsr jamaljsr requested a review from guggero December 14, 2024 16:11
@guggero guggero merged commit 9743009 into master Dec 16, 2024
@guggero guggero deleted the fix-loop-build branch December 16, 2024 08:43
@djkazic
Copy link
Contributor

djkazic commented Dec 19, 2024

AFAICT, this PR causes the looprpc docs to be dropped. I think we can rework it to bring it back in, experimenting locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants