[sql-23] db/sqlc: only use named UNIQUE indices #1000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace any named UNIQUE indices in the accounts tables and replace with named ones. This is for a future where we want to be able to edit these indices without having to drop the table. It is fine for us to just edit these tables since these are not available in "prod" yet.
ellemouton
added
the
no-changelog
bitromortac
approved these changes
Mar 11, 2025
Contributor
bitromortac
left a comment
bitromortac
left a comment
There was a problem hiding this comment.
LGTM, what would be a reason to edit such indices?
Member
Author
Just in case we want to add to the index in future maybe or even just to be consistent incase we want to add another one. But I think also just hard to predict the future use-cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace any named UNIQUE indices in the accounts tables and replace with named ones. This is for a future where we want to be able to edit these indices without having to drop the table.
It is fine for us to just edit these tables since these are not available in "prod" yet.