litcli: Global flags to accept ENV vars overrides. #1007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcaracuel
force-pushed
the
cli_env_global_flags
branch
from
312e6e8 to
ae8f595
Compare
ViktorT-11
approved these changes
Mar 20, 2025
Contributor
ViktorT-11
left a comment
ViktorT-11
left a comment
There was a problem hiding this comment.
Thanks a lot for this @gcaracuel 🙏🔥!
tACK LGTM 🚀!
| state](https://github.com/lightninglabs/lightning-terminal/pull/985) instead | ||
| of the Revoked state if it is in fact being revoked due to the session expiry | ||
| being reached. | ||
| * [`litcli`: global flags to allow overrides via environment variables](https://github.com/lightninglabs/lightning-terminal/pull/1007) `lncli` --help for more details. |
Contributor
There was a problem hiding this comment.
I would potentially put this under the ### Functional Changes/Additions section instead. Also, feel free to add your name or github profile name under # Contributors (Alphabetical Order) if you'd like to be represented there.
bitromortac
requested changes
Mar 21, 2025
Contributor
bitromortac
left a comment
bitromortac
left a comment
There was a problem hiding this comment.
Thanks for this contribution 🎉! Just have a small request.
gcaracuel
force-pushed
the
cli_env_global_flags
branch
2 times, most recently
from
16cdec6 to
19681fe
Compare
gcaracuel
force-pushed
the
cli_env_global_flags
branch
from
19681fe to
b2f2ea0
Compare
ViktorT-11
approved these changes
Mar 24, 2025
bitromortac
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to global flags to de config using ENV variables.
This is useful when running
litcliin containers.More context at this very same change applied over
lncli-> lightningnetwork/lnd#7693