re-use createNormalInvoice in createAndPayNormalInvoiceWithBtc

[ZZiigguurraatt]

small elimination of unnecessary redundant code

[ellemouton]

@ZZiigguurraatt - could you just update the commit message to use the standard structure pls? 🙏 thanks

[ZZiigguurraatt]

@ZZiigguurraatt - could you just update the commit message to use the standard structure pls? 🙏 thanks

Where do I find a definition of the standard structure so that I can do that properly?

[guggero]

It's not linked specifically in all our projects but we try to follow these guidelines everywhere: https://github.com/lightningnetwork/lnd/blob/master/docs/code_contribution_guidelines.md

[ZZiigguurraatt]

OK. how is the new commit message I've just changed to?

[ViktorT-11]

OK. how is the new commit message I've just changed to?

I recommend you to also read how commit messages should be prefixed according to the golang convention docs, which is also linked in our contribution guidelines: https://go.dev/doc/contribute#commit_messages

In practise, your commit message title here should be prefixed by the primary affected package (itest in this case). Also, you shouldn't capitalize the first word in the commit title. Other than that, your commit message looks good IMO :).
If anything, the title would potentially be even clearer if phrased as:
itest: utilise createNormalInvoice helper

But I'll let you decide on that phrasing as that's very nit-picky :)

[ZZiigguurraatt]

OK, looks good now?