[sql-36] actions: prepare ActionsDB interface #1069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we can easily add a different implementation and swop them out later.
The current ActionLocator is very specific to how actions are stored in the bbolt db. In our SQL implementation, we will simply have an auto-incrementing int64 that we will use as our locator for any action. In preparation for this, we make ActionLocator an abstract interface and implement our bbolt version of it.
Use a helper to compare Actions and prepare the timestamp comparisons so that they are ready for our SQL implementation of the Actions DB.
ellemouton
added
sql-ize
no-changelog
bitromortac
approved these changes
May 12, 2025
| require.Len(t, actions, 0) | ||
|
|
||
| id, err := db.AddAction(ctx, action1) | ||
| _, err = db.AddAction(ctx, action1) |
There was a problem hiding this comment.
perhaps we could still check uniqueness of the locator, by replacing isActionLocator with a representation() string that we could compare? that way we would have at least some utility in the interface-definding method
There was a problem hiding this comment.
if it's ok, im gonna leave it as is cause:
- this is a pretty standard pattern in go
- the correctness of the locator is already tested below when we use locator 2 to update the state of an action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here, we add an abstract
ActionsDBinterface that we will later add a SQL implementation for.Part of #917