Skip to content

Conversation

@guggero
Copy link
Contributor

@guggero guggero commented May 15, 2025

Shows that lightninglabs/taproot-assets#1537 restores backward compatibility.

@guggero guggero force-pushed the backward-compat-itest branch from f8609b2 to 84120f9 Compare May 16, 2025 14:16
Copy link
Contributor

@gijswijs gijswijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised by how small this commit is! Great work.
Made some small remarks, but otherwise LGTM!

@guggero guggero force-pushed the backward-compat-itest branch from 84120f9 to 03cc92b Compare May 16, 2025 16:41
guggero added 2 commits May 16, 2025 18:52
Before this commit the backward compatibility would fail and channels
would force close. But by updating to the fixed version of tap, the
backward compat test should succeed.
@guggero guggero force-pushed the backward-compat-itest branch from 03cc92b to ac33a2a Compare May 16, 2025 16:52
@guggero guggero merged commit b16ecd9 into master May 16, 2025
19 of 22 checks passed
@guggero guggero deleted the backward-compat-itest branch May 16, 2025 19:45
@ellemouton
Copy link
Member

WOW this is very cool!!!
cc @ViktorTigerstrom - we could potentially use this in itests for testing the new migrations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants