-
Notifications
You must be signed in to change notification settings - Fork 109
WIP: go.mod: bump lnd, loop, taproot-assets, taprpc, lndclient #1173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @ffranr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on updating the project's Go module dependencies to newer versions. The changes ensure that the application integrates the latest iterations of critical components like Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates several dependencies in go.mod, including lndclient, taproot-assets, and taprpc. The changes look good overall. I've added one comment regarding a version inconsistency for taprpc in the litrpc submodule that should be addressed to keep the workspace tidy. Additionally, for clarity, you might want to update the PR title to reflect that taproot-assets is being bumped to a pseudo-version rather than the v0.7.0 release tag.
19bff98 to
4b9efca
Compare
|
I'll update this PR once we have new tags for tap. |
4b9efca to
906d251
Compare
4baa75a to
81869aa
Compare
|
Just FYI @ffranr, itests are failing as we need this fix: In order to use |
aaad57b to
26a36c3
Compare
Target versions: * [email protected] * [email protected] * [email protected] * taproot-assets/[email protected] * [email protected]
26a36c3 to
e83c492
Compare
- add waitForChainNotifierReady helper that retries RegisterBlockEpochNtfn until the notifier accepts a stream or the context cancels - call the helper immediately after the full lnd client connects so every integrated subserver starts only after lnd’s chain notifier is ready
e83c492 to
f478f00
Compare
|
|
||
| ### LND | ||
|
|
||
| * Updated [`lnd` to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't make sense to keep this update in the changelog right? Since 0.16.0 updates to 0.20.0-beta and not 0.20.0-beta.rc2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been thinking about that also. I think it would be unnecessarily costly to, as standard, reconcile the release doc across all changes such that it reflected the final release state only. Personally, i think that it's sufficient that it's a sort of append only list of changes.
|
|
||
| ### Loop | ||
|
|
||
| * Updated [`loop` to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same remark here
|
|
||
| ### Taproot Assets | ||
|
|
||
| * Updated [`taproot-assets` to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here
Work in progress. PR opened for early CI feedback.
Target Versions
[email protected][email protected][email protected]taproot-assets/[email protected][email protected]Remaining Steps
mainin tap.