Skip to content

Conversation

@ffranr
Copy link
Contributor

@ffranr ffranr commented Nov 13, 2025

Work in progress. PR opened for early CI feedback.

Target Versions

Remaining Steps

  • Tag [email protected] and taproot-assets/[email protected] on main in tap.
  • Update the loop PR with the new tap tags, merge it, then cut the loop tag.
  • Update this PR with the final tags for loop, taproot-assets, and taproot-assets/taprpc, then merge this PR.

@ffranr ffranr self-assigned this Nov 13, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @ffranr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the project's Go module dependencies to newer versions. The changes ensure that the application integrates the latest iterations of critical components like lndclient, taproot-assets, taprpc, and runc, which can bring improved stability, performance, or new features. This is an initial step to validate the compatibility of these updates within the project's CI environment.

Highlights

  • Dependency Updates: The go.mod file has been updated to bump several key dependencies, including lndclient, taproot-assets, taprpc, and runc to their latest versions.
  • Work in Progress: This pull request is marked as a Work in Progress, primarily opened to gather early continuous integration feedback on the dependency changes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several dependencies in go.mod, including lndclient, taproot-assets, and taprpc. The changes look good overall. I've added one comment regarding a version inconsistency for taprpc in the litrpc submodule that should be addressed to keep the workspace tidy. Additionally, for clarity, you might want to update the PR title to reflect that taproot-assets is being bumped to a pseudo-version rather than the v0.7.0 release tag.

@ffranr ffranr force-pushed the wip/bump-tapd-v0.7.0 branch from 19bff98 to 4b9efca Compare November 13, 2025 15:55
@ffranr
Copy link
Contributor Author

ffranr commented Nov 13, 2025

I'll update this PR once we have new tags for tap.

@ffranr ffranr force-pushed the wip/bump-tapd-v0.7.0 branch from 4b9efca to 906d251 Compare November 13, 2025 21:20
@ffranr ffranr changed the title WIP: go.mod: bump [email protected], taprpc, [email protected] WIP: go.mod: bump lnd, loop, taproot-assets, taprpc, lndclient Nov 13, 2025
@ffranr ffranr force-pushed the wip/bump-tapd-v0.7.0 branch 2 times, most recently from 4baa75a to 81869aa Compare November 13, 2025 22:58
@ViktorT-11
Copy link
Contributor

Just FYI @ffranr, itests are failing as we need this fix:
#1170
& the dependent lndclient PR:
lightninglabs/lndclient#255

In order to use lnd v0.20.0-beta.rc3+.

@ffranr ffranr force-pushed the wip/bump-tapd-v0.7.0 branch 2 times, most recently from aaad57b to 26a36c3 Compare November 14, 2025 12:06
@ffranr ffranr force-pushed the wip/bump-tapd-v0.7.0 branch from 26a36c3 to e83c492 Compare November 14, 2025 12:45
- add waitForChainNotifierReady helper that retries
  RegisterBlockEpochNtfn until the notifier accepts a stream or the
  context cancels
- call the helper immediately after the full lnd client connects so
  every integrated subserver starts only after lnd’s chain notifier is
  ready
@ffranr ffranr force-pushed the wip/bump-tapd-v0.7.0 branch from e83c492 to f478f00 Compare November 14, 2025 12:54

### LND

* Updated [`lnd` to

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't make sense to keep this update in the changelog right? Since 0.16.0 updates to 0.20.0-beta and not 0.20.0-beta.rc2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been thinking about that also. I think it would be unnecessarily costly to, as standard, reconcile the release doc across all changes such that it reflected the final release state only. Personally, i think that it's sufficient that it's a sort of append only list of changes.


### Loop

* Updated [`loop` to

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same remark here


### Taproot Assets

* Updated [`taproot-assets` to

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants