Fix multi-rfq itest flake

[GeorgeTsagk]

Description

Bumps the version of LND in order to include some TrafficShaper / AuxBandwidth fixes

[gemini-code-assist]

Summary of Changes

Hello @GeorgeTsagk, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily addresses a flaking multi-rfq integration test by upgrading the lnd dependency to a newer beta version that includes critical TrafficShaper and AuxBandwidth fixes. Additionally, the test itself has been improved to use unique payment preimages, and backward compatibility for this specific test has been temporarily disabled to allow for a more stable resolution in an upcoming release.

Highlights

• LND Version Bump: The lnd dependency has been updated to a newer beta version (v0.20.0-beta.rc4...) to incorporate fixes related to TrafficShaper and AuxBandwidth.
• Neutrino Cache Update: The neutrino/cache dependency has been bumped from v1.1.2 to v1.1.3.
• Temporary LND Fork: go.mod now includes replace directives pointing lnd and lnd/sqldb to a specific commit in the author's personal fork, likely for testing or incorporating unmerged fixes.
• Multi-RFQ Test Flake Fix: The testCustomChannelsMultiRFQ integration test now generates a random preimage for hold invoices, ensuring unique payment hashes and addressing a potential flakiness issue.
• Backward Compatibility Disabled: The backwardCompat entry for the testCustomChannelsMultiRFQ test has been temporarily commented out, awaiting a stability fix in a future LiT tag.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to fix a flaky integration test (multi-rfq itest flake) by updating the LND dependency to include fixes for TrafficShaper / AuxBandwidth. The changes include bumping the LND version in go.mod, updating a test to be more self-contained, and temporarily disabling a backward compatibility test.

My main concern is the use of replace directives in go.mod to point to a personal fork of lnd. This is a temporary solution and should be replaced with a proper dependency update once the required changes are available in an official upstream release. I've added a high-severity comment regarding this.

Additionally, I've noted the temporary disabling of a backward compatibility test, which should be tracked and re-enabled in the future. The changes to the integration test logic itself appear correct and should improve test stability.

[gemini-code-assist]

These replace directives point to a personal fork (github.com/GeorgeTsagk/lnd). While this might be necessary for an urgent fix, it's not a sustainable solution for the main branch. This introduces a dependency on a non-standard repository, which can cause issues with maintenance, security, and future updates.

Please ensure there's a plan to remove these directives by either getting the changes merged upstream into github.com/lightningnetwork/lnd and updating the dependency version, or by vendoring the required code if it's a long-term fork. This should be addressed before this PR is merged into a release branch.

[gemini-code-assist]

The backward compatibility test for custom channels multi rfq has been disabled. The comment indicates this is a temporary measure. It's important to track this and re-enable the test once the stability fix is included in a tagged LiT release to ensure long-term compatibility is maintained.

[jtobin]

Linking lightningnetwork/lnd#10434, which should bring the requisite fixes into lnd.

[lightninglabs-deploy]

@GeorgeTsagk, remember to re-request review from reviewers when ready