itest: have tapd skip cert verification

[jtobin]

(Depends on lightninglabs/taproot-assets#1775.)

The mock oracle uses a self-signed certificate for TLS, but we're not concerned with having tapd verify it in the itest environment. This commit adds the 'experimental.rfq.priceoracletlsinsecure' flag to the litd args list, instructing tapd not to verify certificates.

[gemini-code-assist]

Summary of Changes

Hello @jtobin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue in the integration test suite where tapd would fail to establish a connection with the mock price oracle due to its use of a self-signed TLS certificate. By introducing a specific flag to disable TLS verification for the oracle connection within the test environment, it ensures that integration tests can execute without encountering certificate-related errors, streamlining the testing process.

Highlights

• Mock Oracle TLS Verification: The tapd component will now skip TLS certificate verification when connecting to the mock price oracle within the integration test environment.
• Configuration Flag Added: This behavior is enabled by adding the --taproot-assets.experimental.rfq.priceoracletlsinsecure flag to the litd arguments in the itest suite.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces the --taproot-assets.experimental.rfq.priceoracletlsinsecure flag to the litd arguments in several integration tests. This change is necessary to allow tapd to skip TLS certificate verification when communicating with the mock oracle, which uses a self-signed certificate. The implementation is correct and effectively addresses the issue. My review includes a suggestion to define the new flag as a constant to improve code maintainability by reducing string literal duplication.

[lightninglabs-deploy]

@jtobin, remember to re-request review from reviewers when ready