Skip to content

build: bump google-protobuf dep #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2024
Merged

build: bump google-protobuf dep #850

merged 2 commits into from
Sep 23, 2024

Conversation

@djkazic
Copy link
Contributor

@djkazic djkazic commented Sep 22, 2024

Today, the presence of a channel with peer_scid_alias on (more accurately, if it has entries for alias_scids) will cause a binary deserialization fail with the error:

t.isDelimited is not a function
  at Object.readMessage
  at Function.deserializeBinaryFromReader
  at Function.deserializeBinary
  at Array.forEach
  at e.onTransportChunk

This happens inside grpc-web, but it's due to an outdated google-protobuf dependency. This PR upgrades it.

ellemouton
ellemouton reviewed Sep 23, 2024
View reviewed changes
ellemouton
ellemouton approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@djkazic djkazic force-pushed the update-google-protobuf branch from 4b2050f to 4dcd940 Compare September 23, 2024 02:26
ViktorT-11
ViktorT-11 approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@ViktorT-11 ViktorT-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! Awesome work & investigation 🚀🎉!

jamaljsr
jamaljsr approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK LGTM 🚀

@jamaljsr jamaljsr merged commit 43ac9fa into master Sep 23, 2024
13 checks passed
@jamaljsr jamaljsr deleted the update-google-protobuf branch September 23, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamaljsr jamaljsr jamaljsr approved these changes

@ViktorT-11 ViktorT-11 ViktorT-11 approved these changes

@ellemouton ellemouton ellemouton approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@djkazic @jamaljsr @ViktorT-11 @ellemouton