itest: Extend liquidity edge cases for custom channels #861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeTsagk
changed the title
guggero
approved these changes
Oct 14, 2024
GeorgeTsagk
force-pushed
the
enhance-custom-chan-liquidity-test
branch
from
e2a04fd to
e14ada2
Compare
|
Cursory glance at the diff, I see many large payments -- is the testing of super small payments sufficient? Users will attempt to demo payments of minimal amounts |
|
@dstadulis good point, can add coverage |
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few more edge cases in the custom channel liquidity edge cases itest.
These extra cases cover scenarios of big payments going through an asset channel, where the asset amount expressed in btc exceeds the btc channel capacity.