make: update VERSION_TAG to a globally-consistent build-input identifier #864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
approved these changes
Oct 11, 2024
make/release_flags.mk
Outdated
| @@ -1,4 +1,5 @@ | |||
| VERSION_TAG = $(shell git describe --tags) | |||
| # Create globally-consistent, build-input identifier | |||
There was a problem hiding this comment.
nit: comments should always be full sentences, including punctuation.
There was a problem hiding this comment.
i.e. "Add a full stop"? [Edit: Yes]
CMIIW but "{Imperative verb} {adjective} {direct objective}" is a complete sentence.
There was a problem hiding this comment.
yup, just update it to: # Create globally-consistent, build-input identifier.
ellemouton
approved these changes
Oct 14, 2024
Additional flags produce: * Globally consistent commitment hash length, regardless of gitconfig * `--broken` to create fail-safe tag indicating a dirty or corrupted work tree * `--always` to generate a tag, even if no tags are reachable from the current commit.
ellemouton
force-pushed
the
globally-consistent-build-input-identifier
branch
from
f79939e to
66d2bd1
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #863 #854
Additional flags produce:
--brokento create fail-safe tag indicating a dirty or corruptedwork tree
--alwaysto generate a tag, even if no tags are reachable from thecurrent commit.