litcli: relax fundchannel checks #865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
approved these changes
Oct 11, 2024
GeorgeTsagk
approved these changes
Oct 11, 2024
guggero
reviewed
Oct 11, 2024
gijswijs
force-pushed
the
relax-fundchannel-checks
branch
from
599c1ae to
d5b3328
Compare
The RPC calls were updated to allow composite UTXOs (assets from multiple asset utxos) for funding capability, but the same functionality is not available in the CLI due to the existing sanity check. This commits changes the sanity check to allow for composite UTXOs by validating whether the running sum of the assets in the UTXOs is greater than the amount to be funded.
gijswijs
force-pushed
the
relax-fundchannel-checks
branch
from
d5b3328 to
2a50a51
Compare
guggero
approved these changes
Oct 11, 2024
|
Merge Sign! |
dstadulis
merged commit ccbbb55
into
2024-09-0_19_reproducible-releases
13 checks passed
1 task
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes lightninglabs/taproot-assets#1142
The RPC calls were updated to allow composite UTXOs (assets from multiple asset utxos) for funding capability, but the same functionality is not available in the CLI due to the existing sanity check.
This commits changes the sanity check to allow for composite UTXOs by validating whether the running sum of the assets in the UTXOs is greater than the amount to be funded.