itest: add test for consistent balance reporting #871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
5 tasks
gijswijs
force-pushed
the
balance-itest
branch
8 times, most recently
from
e7c40a9 to
091b201
Compare
guggero
changed the base branch from
2024-09-0_19_reproducible-releases
to
0-19-staging
|
Needs a rebase after changing the base branch. |
`assertAssetBalance` would not return an error in the edge case where the requested `assetID` had no balance but the `expectedBalance` was non-zero. This commit fixes the behavior in that specific edge case.
gijswijs
force-pushed
the
balance-itest
branch
from
091b201 to
a7e8150
Compare
guggero
approved these changes
Oct 21, 2024
This commit adds an integration test to ensure consistent balance reporting across various scenarios. The test covers custom channel funding and list balance operations to verify that balance information is accurately reported between lnd's `ChannelBalance` and tapd's `ListBalance` RPCs, without accidental double reporting. (temp) build: bump tapd This commit bumps tapd to the this commit: lightninglabs/taproot-assets@31d333c This commit should be dropped before merging in the main branch.
gijswijs
force-pushed
the
balance-itest
branch
from
a7e8150 to
8526f90
Compare
guggero
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want proper asset balance reporting between lnd and tapd, without asset balances turing up in both the asset balance from tapd and the custom channel balance from lnd.
Currently this behavior is not aligned with that requirement. tapd has currently now way of not reporting asset balances that are actually part of the funding transaction of a custom channel. This is fixed with taproot-assets PR 1151
The current PR under review here is dependent on the taproot-assets commit:
lightninglabs/taproot-assets@31d333c
Bumping the tap version was included in this commit 5bbf3d7 and that commit should probably be edited once 1151 is merged.