Skip to content

Build improvements #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 7, 2024
Merged

Build improvements #890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9370c91
accounts: split mocks
guggero Jul 29, 2024
7cead01
make+perms: allow itest to run with dev build tag
guggero May 23, 2024
a7aabcd
make: add flake-itest-only goal
guggero Jun 26, 2024
f50fb91
GitHub: upload logs on failure
guggero Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ jobs:

strategy:
matrix:
node_version: [16.x]
os: [ubuntu-latest, windows-latest, macOS-latest]
node_version: [ 16.x ]
os: [ ubuntu-latest, windows-latest, macOS-latest ]

steps:
- name: git checkout
Expand Down Expand Up @@ -63,8 +63,8 @@ jobs:

strategy:
matrix:
go_version: [1.18.x]
os: [ubuntu-latest, windows-latest, macOS-latest]
go_version: [ 1.18.x ]
os: [ ubuntu-latest, windows-latest, macOS-latest ]

steps:
- name: git checkout
Expand All @@ -84,7 +84,7 @@ jobs:

- name: build backend binary
run: make build

- name: build CLI binaries
run: make go-install-cli

Expand Down Expand Up @@ -244,6 +244,19 @@ jobs:
- name: run check
run: make itest

- name: Zip log files on failure
if: ${{ failure() }}
timeout-minutes: 5
run: 7z a logs-itest.zip itest/**/*.log

- name: Upload log files on failure
uses: actions/upload-artifact@v3
if: ${{ failure() }}
with:
name: logs-itest
path: logs-itest.zip
retention-days: 5

########################
# check PR updates release notes
########################
Expand All @@ -256,4 +269,4 @@ jobs:
uses: actions/checkout@v3

- name: release notes check
run: scripts/check-release-notes.sh
run: scripts/check-release-notes.sh
6 changes: 5 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ DOCKER_TOOLS = docker run \
-v $(shell bash -c "mkdir -p /tmp/go-lint-cache; echo /tmp/go-lint-cache"):/root/.cache/golangci-lint \
-v $$(pwd):/build litd-tools

ITEST_TAGS := integration itest $(LND_RELEASE_TAGS)
ITEST_TAGS := dev integration itest lowscrypt $(LND_RELEASE_TAGS)
Copy link
Contributor

@ViktorT-11 ViktorT-11 Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I'm not fully sure why the lowscrypt buildtag is added here? Maybe the commit message could be extended to specify that as well if this is intended :)

Copy link
Contributor Author

@guggero guggero Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right. Speeds up wallet creation by using weaker encryption. Added that to the commit message.

ITEST_LDFLAGS := $(call make_ldflags, $(ITEST_TAGS))

GREEN := "\\033[0;32m"
Expand Down Expand Up @@ -238,6 +238,10 @@ flake-unit:
@$(call print, "Flake hunting unit tests.")
while [ $$? -eq 0 ]; do GOTRACEBACK=all $(UNIT) -count=1; done

flake-itest-only:
@$(call print, "Flake hunting integration tests.")
while [ $$? -eq 0 ]; do make itest-only icase='${icase}'; done

# =========
# UTILITIES
# =========
Expand Down
21 changes: 12 additions & 9 deletions accounts/checkers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,13 +513,14 @@ func testSendPayment(t *testing.T, uri string) {
}

lndMock := newMockLnd()
routerMock := newMockRouter()
errFunc := func(err error) {
lndMock.mainErrChan <- err
}
service, err := NewService(t.TempDir(), errFunc)
require.NoError(t, err)

err = service.Start(lndMock, lndMock, chainParams)
err = service.Start(lndMock, routerMock, chainParams)
require.NoError(t, err)

assertBalance := func(id AccountID, expectedBalance int64) {
Expand Down Expand Up @@ -615,7 +616,7 @@ func testSendPayment(t *testing.T, uri string) {
require.NoError(t, err)
assertBalance(acct.ID, 4000)

lndMock.assertPaymentRequests(t, map[lntypes.Hash]struct{}{
routerMock.assertPaymentRequests(t, map[lntypes.Hash]struct{}{
testHash: {},
})

Expand Down Expand Up @@ -646,7 +647,7 @@ func testSendPayment(t *testing.T, uri string) {
// was initiated.
assertBalance(acct.ID, 4000)

lndMock.assertNoPaymentRequest(t)
routerMock.assertNoPaymentRequest(t)

// The final test we will do is to have two send requests initiated
// before the response for the first one has been received.
Expand Down Expand Up @@ -708,13 +709,14 @@ func TestSendPaymentV2(t *testing.T) {
}

lndMock := newMockLnd()
routerMock := newMockRouter()
errFunc := func(err error) {
lndMock.mainErrChan <- err
}
service, err := NewService(t.TempDir(), errFunc)
require.NoError(t, err)

err = service.Start(lndMock, lndMock, chainParams)
err = service.Start(lndMock, routerMock, chainParams)
require.NoError(t, err)

assertBalance := func(id AccountID, expectedBalance int64) {
Expand Down Expand Up @@ -808,7 +810,7 @@ func TestSendPaymentV2(t *testing.T) {
require.NoError(t, err)
assertBalance(acct.ID, 4000)

lndMock.assertPaymentRequests(t, map[lntypes.Hash]struct{}{
routerMock.assertPaymentRequests(t, map[lntypes.Hash]struct{}{
testHash: {},
})

Expand Down Expand Up @@ -836,7 +838,7 @@ func TestSendPaymentV2(t *testing.T) {
// was initiated.
assertBalance(acct.ID, 4000)

lndMock.assertNoPaymentRequest(t)
routerMock.assertNoPaymentRequest(t)

// The final test we will do is to have two send requests initiated
// before the response for the first one has been received.
Expand Down Expand Up @@ -894,13 +896,14 @@ func TestSendToRouteV2(t *testing.T) {
}

lndMock := newMockLnd()
routerMock := newMockRouter()
errFunc := func(err error) {
lndMock.mainErrChan <- err
}
service, err := NewService(t.TempDir(), errFunc)
require.NoError(t, err)

err = service.Start(lndMock, lndMock, chainParams)
err = service.Start(lndMock, routerMock, chainParams)
require.NoError(t, err)

assertBalance := func(id AccountID, expectedBalance int64) {
Expand Down Expand Up @@ -998,7 +1001,7 @@ func TestSendToRouteV2(t *testing.T) {
require.NoError(t, err)
assertBalance(acct.ID, 4000)

lndMock.assertPaymentRequests(t, map[lntypes.Hash]struct{}{
routerMock.assertPaymentRequests(t, map[lntypes.Hash]struct{}{
testHash: {},
})

Expand Down Expand Up @@ -1028,7 +1031,7 @@ func TestSendToRouteV2(t *testing.T) {
// was initiated.
assertBalance(acct.ID, 4000)

lndMock.assertNoPaymentRequest(t)
routerMock.assertNoPaymentRequest(t)

// The final test we will do is to have two send requests initiated
// before the response for the first one has been received.
Expand Down
Loading
Loading