Add itest for MinRelayFee check in tapd #892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
force-pushed
the
update-to-lnd-18-4
branch
from
9c10445 to
a4d76ed
Compare
guggero
force-pushed
the
update-to-lnd-18-4
branch
from
6b38cf0 to
3a8f1f6
Compare
gijswijs
force-pushed
the
validate-fee
branch
3 times, most recently
from
2506456 to
de86073
Compare
|
I've removed the default value of 1 for |
jharveyb
approved these changes
Nov 4, 2024
This commit removes the default value of 1 for `sat_per_vbyte` that's being passed to `litd` rpc endpoint `fundchannel`. `litd` handles this now perfectly on its own, and adding logic here only adds to the confusion.
This commit adds an integration test for the MinRelayFee check. The test ensures that transactions with fees below the minimum relay fee are rejected.
gijswijs
force-pushed
the
validate-fee
branch
from
b4a86ac to
13fa097
Compare
guggero
approved these changes
Nov 5, 2024
| }, | ||
| ) | ||
|
|
||
| errFeeRateTooLow := fmt.Sprintf("fee rate %s too low, "+ |
There was a problem hiding this comment.
This actually shows a problem with the sat/vByte fee rate... Because 1 sat/vByte is equal to 250 sat/kw but the absolute minimum relay fee there can ever be is defined as 253 sat/kw, this would mean that you could only fund channels with at least 2 sat/vBytes. Which is kind of unfortunate.
But I think we should fix this in tapd and unrelated to this PR. Just letting you know that this might change again in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an integration test for the MinRelayFee check. The test ensures that transactions with fees below the minimum relay fee are rejected.
This PR depends on lightninglabs/taproot-assets#1163 which in turn depends on lightninglabs/lndclient#200
It uses pseudoversions in
go.modforbothtaproot-assetsandthat should be updated before merging.lndclient