config: disable internal GRPC logger by default #896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GRPC connection logger is very verbose and normally not very useful. So it leads to more confusion and unnecessary log bloat than it actually helps to debug things. So we disable it by default, meaning that if GRPC=<level> doesn't appear in the log level config string, we add GRPC=off. That means we can still manually turn it on by adding ,GRPC=info to the log config (e.g. --lnd.debuglevel=debug,GRPC=info).
ellemouton
approved these changes
Nov 7, 2024
Member
ellemouton
left a comment
ellemouton
left a comment
There was a problem hiding this comment.
AMAZING thank you yes please 🙌 tACK
ellemouton
added
the
no-changelog
ViktorT-11
approved these changes
Nov 7, 2024
Contributor
ViktorT-11
left a comment
ViktorT-11
left a comment
There was a problem hiding this comment.
Awesome, thanks. tACK LGTM 🚀!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GRPC connection logger is very verbose and normally not very useful. So it leads to more confusion and unnecessary log bloat than it actually helps to debug things.
So we disable it by default, meaning that if GRPC= doesn't appear in the log level config string, we add GRPC=off.
That means we can still manually turn it on by adding ,GRPC=info to the log config (e.g. --lnd.debuglevel=debug,GRPC=info).
See #895 for an example where the log is less than useful.