itest: Extend custom channel liquidity itest for RFQ HTLC tracking #906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstadulis
changed the title
GeorgeTsagk
force-pushed
the
rfq-track-htlc-itests
branch
from
6b56147 to
f055328
Compare
guggero
force-pushed
the
update-to-lnd-18-4
branch
from
7cb58a5 to
d82cb9d
Compare
|
@GeorgeTsagk do I only need to review the last three commits? |
GeorgeTsagk
force-pushed
the
rfq-track-htlc-itests
branch
from
f055328 to
e52a8c5
Compare
|
@ffranr this was just rebased, it's just one commit now (if you skip the temp one) |
ffranr
reviewed
Nov 27, 2024
guggero
force-pushed
the
update-to-lnd-18-4
branch
3 times, most recently
from
b0c1550 to
d48feca
Compare
GeorgeTsagk
force-pushed
the
rfq-track-htlc-itests
branch
2 times, most recently
from
9ef04d6 to
82d567c
Compare
guggero
reviewed
Nov 29, 2024
ffranr
reviewed
Dec 2, 2024
GeorgeTsagk
force-pushed
the
rfq-track-htlc-itests
branch
from
82d567c to
262846f
Compare
GeorgeTsagk
force-pushed
the
rfq-track-htlc-itests
branch
2 times, most recently
from
2a8b4ad to
83801f5
Compare
guggero
approved these changes
Dec 4, 2024
ffranr
reviewed
Dec 5, 2024
guggero
force-pushed
the
update-to-lnd-18-4
branch
from
d4505dd to
868e57c
Compare
GeorgeTsagk
force-pushed
the
rfq-track-htlc-itests
branch
from
83801f5 to
acbc6b5
Compare
GeorgeTsagk
force-pushed
the
rfq-track-htlc-itests
branch
from
acbc6b5 to
0381304
Compare
ffranr
approved these changes
Dec 5, 2024
guggero
reviewed
Dec 5, 2024
GeorgeTsagk
force-pushed
the
rfq-track-htlc-itests
branch
from
0381304 to
99ab0ce
Compare
|
Will wait for base PR to merge, then will update |
guggero
reviewed
Dec 5, 2024
|
|
||
| var rfqBytes []byte | ||
| manualRfq.WhenSome(func(i rfqmsg.ID) { | ||
| copy(rfqBytes, i[:]) |
There was a problem hiding this comment.
copy() is tricky if the target slice is nil or empty, nothing happens. So you need to do rfqBytes = make([]byte, len(i[:])) first.
There was a problem hiding this comment.
Nice catch! Interestingly enough the tests did not fail as the daemon would automatically acquire fresh quotes for the payment. Specifying an rfqID here was a effectively a noop.
The reason this wasn't caught by the next test case (which requires you use a specific rfq scid and none else) is because it is enforced by the receiver, while crafting the invoice.
GeorgeTsagk
force-pushed
the
rfq-track-htlc-itests
branch
from
99ab0ce to
aff79f2
Compare
GeorgeTsagk
force-pushed
the
rfq-track-htlc-itests
branch
from
aff79f2 to
73bbd6a
Compare
GeorgeTsagk
merged commit 82c8511
into
lightninglabs:update-to-lnd-18-4
12 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions
Adds an extra edge case to the custom channels itest which verifieds that the rfq htlc tracking mechanism works as expected.
Related tapd PR: lightninglabs/taproot-assets#1186