[custom channels]: test forward traffic shaper #912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
force-pushed
the
forward-traffic-shaper
branch
from
9db23ae to
98c9819
Compare
GeorgeTsagk
reviewed
Dec 5, 2024
guggero
force-pushed
the
update-to-lnd-18-4
branch
from
d4505dd to
868e57c
Compare
guggero
force-pushed
the
forward-traffic-shaper
branch
2 times, most recently
from
07497a9 to
b41c464
Compare
guggero
force-pushed
the
update-to-lnd-18-4
branch
from
82c8511 to
e413905
Compare
guggero
force-pushed
the
forward-traffic-shaper
branch
2 times, most recently
from
492d1e6 to
8249b69
Compare
guggero
force-pushed
the
forward-traffic-shaper
branch
from
8249b69 to
03db2c7
Compare
|
Will need to highly prioritize for rc2 |
guggero
force-pushed
the
update-to-lnd-18-4
branch
from
8ac370b to
8371d03
Compare
guggero
force-pushed
the
forward-traffic-shaper
branch
from
03db2c7 to
59a6553
Compare
ffranr
approved these changes
Dec 10, 2024
Comment on lines
+3620
to
+3623
| t.Logf("Got quote for %v asset units at %3f msat/unit from peer %s "+ | ||
| "with SCID %d", numUnits, msatPerUnit, erin.PubKeyStr, | ||
| quote.AcceptedQuote.Scid) |
There was a problem hiding this comment.
In general, I think it would be better if log messages were written with args at the end:
t.Logf("Got quote from peer (asset_units=%v, msat_to_asset_units=%3f, peer=%s, "+
"scid=%d)", numUnits, msatPerUnit, erin.PubKeyStr,
quote.AcceptedQuote.Scid)
There was a problem hiding this comment.
Yeah, I generally agree. And with the new slog based logging library we'll be able to do that in a more generalized manner (at least in lnd).
For now I'm trying to keep this aligned with other such messages in other tests.
guggero
force-pushed
the
forward-traffic-shaper
branch
from
59a6553 to
a08e051
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on lightningnetwork/lnd#9333.Depends on lightninglabs/taproot-assets#1236.
Makes sure channels aren't force closed in certain edge cases.