[sql-5] accounts: use clock.Clock #944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellemouton
added
no-changelog
ellemouton
force-pushed
the
sql5Accounts5
branch
from
e0f0535 to
54bb961
Compare
bitromortac
approved these changes
Jan 22, 2025
Contributor
bitromortac
left a comment
bitromortac
left a comment
There was a problem hiding this comment.
LGTM 🎉 this comment could be addressed here #941 (comment)
In this commit, we use the clock.Clock type instead of directly calling time.Now().
ellemouton
force-pushed
the
sql5Accounts5
branch
from
54bb961 to
42a4c82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we use the clock.Clock type instead of directly calling time.Now().
This is in preparation for cleaner testing against different SQL backends later on in the series.