Update tapd to v0.5.1-alpha.rc1, bump version to v0.14.1-alpha.rc1 #950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellemouton
approved these changes
Jan 22, 2025
ViktorT-11
approved these changes
Jan 22, 2025
Contributor
ViktorT-11
left a comment
ViktorT-11
left a comment
There was a problem hiding this comment.
LGTM except a small nit that's non-blocking.
One more nit, is that the version bump is not the last commit in the PR.
guggero
force-pushed
the
bump-tapd-0-5-1-rc1
branch
from
9991dd6 to
db23a1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.