Skip to content

GitHub+accounts: fix i386 compilation issue #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 23, 2025
Merged

GitHub+accounts: fix i386 compilation issue #951

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
474080f
GitHub: update actions/checkout to v4
guggero Jan 23, 2025
f8881cc
GitHub: add key-prefix and use-build-cache to setup-go action
guggero Jan 23, 2025
4a3a628
GitHub: add Golang cross compilation check
guggero Jan 23, 2025
1657584
accounts: fix compilation issue for i386 systems
guggero Jan 23, 2025
2f72da0
GitHub: fix permission denied in lint CI step
guggero Jan 23, 2025
415e589
GitHub: cancel jobs for previous pushes of PR
guggero Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions accounts/store_kvdb.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,8 +244,8 @@ func (s *BoltStore) IncreaseAccountBalance(_ context.Context, id AccountID,

update := func(account *OffChainBalanceAccount) error {
if amount > math.MaxInt64 {
return fmt.Errorf("amount %d exceeds the maximum of %d",
amount, math.MaxInt64)
return fmt.Errorf("amount %v exceeds the maximum of %v",
amount, int64(math.MaxInt64))
Comment on lines +247 to +248
Copy link
Member

@ellemouton ellemouton Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very interesting!

}

account.CurrentBalance += int64(amount)
Expand Down
Loading