[sql-8]: run itests against all DB types

itest/litd_node.go

@@ -8,6 +8,7 @@ import (
 	"encoding/hex"
 	"encoding/json"
 	"errors"
+	"flag"
 	"fmt"
 	"io"
 	"io/ioutil"
@@ -25,6 +26,7 @@ import (
 	"github.com/btcsuite/btcd/wire"
 	"github.com/lightninglabs/faraday/frdrpc"
 	terminal "github.com/lightninglabs/lightning-terminal"
+	"github.com/lightninglabs/lightning-terminal/db"
 	"github.com/lightninglabs/lightning-terminal/litrpc"
 	"github.com/lightninglabs/lightning-terminal/subservers"
 	"github.com/lightninglabs/loop/looprpc"
@@ -60,7 +62,12 @@ var (
 	numActiveNodes    = 0
 	numActiveNodesMtx sync.Mutex
 
-	defaultLndPassphrase = []byte("default-wallet-password")
+	// litDBBackend is a command line flag for specifying the database
+	// backend to use when starting a LiT daemon.
+	litDBBackend = flag.String(
+		"litdbbackend", terminal.DatabaseBackendBbolt, "Set the "+
+			"database backend to use when starting a LiT daemon.",
+	)
 )
 
 type LitNodeConfig struct {
@@ -80,6 +87,9 @@ type LitNodeConfig struct {
 	LitTLSCertPath string
 	LitMacPath     string
 
+	DBBackend      string
+	PostgresConfig *db.PostgresConfig
+
 	UIPassword string
 	LitDir     string
 	FaradayDir string
@@ -220,8 +230,20 @@ func (cfg *LitNodeConfig) defaultLitdArgs() *litArgs {
 			"restcors":               "*",
 			"lnd.debuglevel":         "trace,GRPC=error,PEER=info",
 			"lndconnectinterval":     "200ms",
+			"databasebackend":        cfg.DBBackend,
 		}
 	)
+
+	if cfg.DBBackend == terminal.DatabaseBackendPostgres {
+		args["postgres.host"] = cfg.PostgresConfig.Host
+		args["postgres.port"] = fmt.Sprintf(
+			"%d", cfg.PostgresConfig.Port,
+		)
+		args["postgres.user"] = cfg.PostgresConfig.User
+		args["postgres.password"] = cfg.PostgresConfig.Password
+		args["postgres.dbname"] = cfg.PostgresConfig.DBName
+	}
+
 	for _, arg := range cfg.LitArgs {
 		parts := strings.Split(arg, "=")
 		option := strings.TrimLeft(parts[0], "--")
@@ -417,6 +439,28 @@ func NewNode(t *testing.T, cfg *LitNodeConfig,
 	cfg.LitTLSCertPath = filepath.Join(cfg.LitDir, "tls.cert")
 	cfg.GenerateListeningPorts()
 
+	// Decide which DB backend to use.
+	switch *litDBBackend {
+	case terminal.DatabaseBackendSqlite:
+		cfg.DBBackend = terminal.DatabaseBackendSqlite
+
+	case terminal.DatabaseBackendPostgres:
+		fixture := db.NewTestPgFixture(
+			t, db.DefaultPostgresFixtureLifetime, true,
+		)
+		t.Cleanup(func() {
+			fixture.TearDown(t)
+		})
+
+		cfg.DBBackend = terminal.DatabaseBackendPostgres
+		cfg.PostgresConfig = fixture.GetConfig()
+
+	default:
+		cfg.DBBackend = terminal.DatabaseBackendBbolt
+	}
+
+	t.Logf("Using %v database backend", cfg.DBBackend)
+
 	// Generate a random UI password by reading 16 random bytes and base64
 	// encoding them.
 	var randomBytes [16]byte

make/testing_flags.mk

@@ -1,6 +1,5 @@
 include make/compile_flags.mk
 
-ITEST_FLAGS =
 TEST_FLAGS =
 DEV_TAGS = dev
 
@@ -9,6 +8,11 @@ ifneq ($(icase),)
 ITEST_FLAGS += -test.run="TestLightningTerminal/$(icase)"
 endif
 
+# Run itests with specified db backend.
+ifneq ($(dbbackend),)
+ITEST_FLAGS += -litdbbackend=$(dbbackend)
+endif
+
 # If a specific unit test case is being targeted, construct test.run filter.
 ifneq ($(case),)
 TEST_FLAGS += -test.run=$(case)

terminal.go

@@ -216,7 +216,7 @@ type LightningTerminal struct {
 	middleware        *mid.Manager
 	middlewareStarted bool
 
-	accountsStore         *accounts.BoltStore
+	accountsStore         accounts.Store
 	accountService        *accounts.InterceptorService
 	accountServiceStarted bool
 
@@ -415,10 +415,14 @@ func (g *LightningTerminal) start(ctx context.Context) error {
 		)
 	}
 
-	g.accountsStore, err = accounts.NewBoltStore(
-		filepath.Dir(g.cfg.MacaroonPath), accounts.DBFilename,
-		clock.NewDefaultClock(),
-	)
+	networkDir := filepath.Join(g.cfg.LitDir, g.cfg.Network)
+	err = makeDirectories(networkDir)
+	if err != nil {
+		return fmt.Errorf("could not create network directory: %v", err)
+	}
+
+	clock := clock.NewDefaultClock()
+	g.accountsStore, err = NewAccountStore(g.cfg, clock)
 	if err != nil {
 		return fmt.Errorf("error creating accounts store: %w", err)
 	}
@@ -445,10 +449,7 @@ func (g *LightningTerminal) start(ctx context.Context) error {
 	g.ruleMgrs = rules.NewRuleManagerSet()
 
 	// Create an instance of the local Terminal Connect session store DB.
-	networkDir := filepath.Join(g.cfg.LitDir, g.cfg.Network)
-	g.sessionDB, err = session.NewDB(
-		networkDir, session.DBFilename, clock.NewDefaultClock(),
-	)
+	g.sessionDB, err = session.NewDB(networkDir, session.DBFilename, clock)
 	if err != nil {
 		return fmt.Errorf("error creating session DB: %v", err)
 	}