-
Notifications
You must be signed in to change notification settings - Fork 109
accounts: add functionality to update balance by given amount #962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
ViktorT-11
wants to merge
10
commits into
lightninglabs:master
from
ViktorT-11:2025-02-accounts-cli-update-rework
Closed
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
32eb4c5
accounts: add SQL store implementation
ellemouton 21c0677
make+GH: helpers for testing against new SQL stores
ellemouton 8c24c1a
litrpc: run `go mod tidy`
ViktorT-11 755068b
multi: add accounts `UpdateBalance` endpoint
ViktorT-11 3cd1569
litcli: add `updatebalance` command
ViktorT-11 078ca5f
accounts: implement kvdb `AdjustAccountBalance`
ViktorT-11 a01233b
accounts: implement sqlc `AdjustAccountBalance`
ViktorT-11 debfa05
accounts: add `AdjustAccountBalance` store tests
ViktorT-11 54005b0
accounts: implement `UpdateBalance` endpoint
ViktorT-11 aed7ef3
docs: update release notes
ViktorT-11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just an idea for standard PR flow: we always try to (as much as possible at least) to keep commits ordered such that things are working commit by commit. For 2 reasons: 1) reverting back to any single commit isnt a problem and 2) review story telling.
so the ideal flow for RPC additions is:
the high level pattern im describing here is:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the suggestion! I've tried to follow this with the introduction of the new #973 & #974 PRs.