Skip to content
Closed
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,8 @@ jobs:
unit_type:
- unit-race
- unit
- unit dbbackend=postgres
- unit dbbackend=sqlite
steps:
- name: git checkout
uses: actions/checkout@v4
Expand Down
27 changes: 27 additions & 0 deletions accounts/interface.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
package accounts

import (
"bytes"
"context"
"encoding/binary"
"encoding/hex"
"errors"
"fmt"
Expand Down Expand Up @@ -55,6 +57,31 @@ func ParseAccountID(idStr string) (*AccountID, error) {
return &id, nil
}

// ToInt64 converts an AccountID to its int64 representation.
func (a AccountID) ToInt64() (int64, error) {
var value int64
buf := bytes.NewReader(a[:])
if err := binary.Read(buf, byteOrder, &value); err != nil {
return 0, err
}

return value, nil
}

// AccountIDFromInt64 converts an int64 to an AccountID.
func AccountIDFromInt64(value int64) (AccountID, error) {
var (
a = AccountID{}
buf = new(bytes.Buffer)
)
if err := binary.Write(buf, binary.BigEndian, value); err != nil {
return a, err
}
copy(a[:], buf.Bytes())

return a, nil
}

// String returns the string representation of the AccountID.
func (a AccountID) String() string {
return hex.EncodeToString(a[:])
Expand Down
8 changes: 8 additions & 0 deletions accounts/rpcserver.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,14 @@ func (s *RPCServer) UpdateAccount(ctx context.Context,
return marshalAccount(account), nil
}

// UpdateBalance adds or deducts an amount from an existing account in the
Copy link
Member

@ellemouton ellemouton Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just an idea for standard PR flow: we always try to (as much as possible at least) to keep commits ordered such that things are working commit by commit. For 2 reasons: 1) reverting back to any single commit isnt a problem and 2) review story telling.

so the ideal flow for RPC additions is:

  1. add DB/Service functionality along with any tests for those (in small PR world, that could honestly be the whole PR - since that is like 1 unit of code that is easy to reason about and also lets us continue the on the accounts SQL PR while we iterate on the second unit here which is proto/CLI design).
  2. add proto definitions & call the new code from the rpc server code
  3. add CLI calling code

the high level pattern im describing here is:

  1. server implements new functionality but doesnt expose it yet
  2. server exposes new functionality
  3. client starts calling new functionality

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the suggestion! I've tried to follow this with the introduction of the new #973 & #974 PRs.

// account database.
func (s *RPCServer) UpdateBalance(ctx context.Context,
req *litrpc.UpdateAccountBalanceRequest) (*litrpc.Account, error) {

return nil, fmt.Errorf("not implemented")
}

// ListAccounts returns all accounts that are currently stored in the account
// database.
func (s *RPCServer) ListAccounts(ctx context.Context,
Expand Down
Loading