Skip to content

accounts: add functionality to update balance by given amount #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

accounts: add functionality to update balance by given amount #962

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
32eb4c5
accounts: add SQL store implementation
ellemouton Jan 5, 2025
21c0677
make+GH: helpers for testing against new SQL stores
ellemouton Jan 5, 2025
8c24c1a
litrpc: run `go mod tidy`
ViktorT-11 Feb 5, 2025
755068b
multi: add accounts `UpdateBalance` endpoint
ViktorT-11 Feb 5, 2025
3cd1569
litcli: add `updatebalance` command
ViktorT-11 Feb 5, 2025
078ca5f
accounts: implement kvdb `AdjustAccountBalance`
ViktorT-11 Feb 5, 2025
a01233b
accounts: implement sqlc `AdjustAccountBalance`
ViktorT-11 Feb 5, 2025
debfa05
accounts: add `AdjustAccountBalance` store tests
ViktorT-11 Feb 5, 2025
54005b0
accounts: implement `UpdateBalance` endpoint
ViktorT-11 Feb 5, 2025
aed7ef3
docs: update release notes
ViktorT-11 Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions accounts/rpcserver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,14 @@ func (s *RPCServer) UpdateAccount(ctx context.Context,
return marshalAccount(account), nil
}

// UpdateBalance adds or deducts an amount from an existing account in the
Copy link
Member

@ellemouton ellemouton Feb 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just an idea for standard PR flow: we always try to (as much as possible at least) to keep commits ordered such that things are working commit by commit. For 2 reasons: 1) reverting back to any single commit isnt a problem and 2) review story telling.

so the ideal flow for RPC additions is:

  1. add DB/Service functionality along with any tests for those (in small PR world, that could honestly be the whole PR - since that is like 1 unit of code that is easy to reason about and also lets us continue the on the accounts SQL PR while we iterate on the second unit here which is proto/CLI design).
  2. add proto definitions & call the new code from the rpc server code
  3. add CLI calling code

the high level pattern im describing here is:

  1. server implements new functionality but doesnt expose it yet
  2. server exposes new functionality
  3. client starts calling new functionality

Copy link
Contributor Author

@ViktorT-11 ViktorT-11 Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the suggestion! I've tried to follow this with the introduction of the new #973 & #974 PRs.

// account database.
func (s *RPCServer) UpdateBalance(ctx context.Context,
req *litrpc.UpdateAccountBalanceRequest) (*litrpc.Account, error) {

return nil, fmt.Errorf("not implemented")
}

// ListAccounts returns all accounts that are currently stored in the account
// database.
func (s *RPCServer) ListAccounts(ctx context.Context,
Expand Down
43 changes: 43 additions & 0 deletions app/src/types/generated/lit-accounts_pb.d.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

305 changes: 305 additions & 0 deletions app/src/types/generated/lit-accounts_pb.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading