[sql-9] sessions: small sql preparations #967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for adding a new `sql_store.go` file later on.
Keep all KVDB logic contained within the same file.
To better reflect the DB backing the CRUD and to prepare for a new `SQLStore` type.
And move an error here which we plan to use across DB types.
ellemouton
added
the
no-changelog
ellemouton
changed the title
jamaljsr
approved these changes
Feb 11, 2025
Member
jamaljsr
left a comment
jamaljsr
left a comment
There was a problem hiding this comment.
Overall, this looks great 👌. I was able to compile & run litd on regtest with no issues. I also confirmed the unit tests passed.
Regarding the code, the refactors seem pretty straight-forward. I'm still getting familiar with the codebase, so don't have any implementation specific feedback just yet.
ViktorT-11
reviewed
Feb 11, 2025
Contributor
ViktorT-11
left a comment
ViktorT-11
left a comment
There was a problem hiding this comment.
Looks good 🚀! Leaving a comment regarding one nil check that'd be needed with this refactor, but other than that, this looks good to go 🔥
terminal.go
Outdated
| } | ||
| } | ||
|
|
||
| if err := g.sessionDB.Close(); err != nil { |
Contributor
There was a problem hiding this comment.
Should also check that g.sessionDB != nil, incase g.start errors before setting the sessionDB field.
Give the sessionRpcServer access to the session store via the session.Store interface instead of the raw DB pointer. This will make it possible to swop out the implementation (which is currently bbolt) with something else such as a SQL implementation. We move the responsibility of closing the DB to the main LiT server.
ellemouton
force-pushed
the
sql9Sessions1
branch
from
8a2147f to
29f6db7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pure refactor that just does a bit of code-move and variable re-naming in preparation for adding
sqlvariations of things.We also make sure to use the
session.Storeinterface in the code-base instead of the raw DB pointer.Part of #966