[sql-10] sessions: decouple super macaroon helpers from sessions package
#968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and out of the `sessions` directory. This is to avoid import cycles when we start explicitly linking accounts to sessions.
Move this helper to the new macaroons package.
In this commit, we refactor various uses of the session.MacaroonRecipe type outside of the session package. This is to decouple the baking of a super macaroon from the sessions package and will help avoid import cycles in future.
ellemouton
added
no-changelog
ellemouton
changed the title
sessions packagesessions package
Move the MacaroonBaker type to the new macaroons package to avoid import cycles in future.
ellemouton
force-pushed
the
sql10Sessions2
branch
from
33d38dc to
402373c
Compare
jamaljsr
approved these changes
Feb 11, 2025
Member
jamaljsr
left a comment
jamaljsr
left a comment
There was a problem hiding this comment.
tACK LGTM 💪
Tested the build, unit tests, and running litd. All good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pure refactor/code-move PR to move any helper functions and types from the
sessionspackage to the new
macaroonspackage. This is to help avoid import cycles later on whenthe session package starts to import from the accounts package (for when a session links to an
account) which also makes use of these macaroon helpers/types.
Part of #966