Skip to content

sessions: strict state shifts #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 25, 2025
Merged

sessions: strict state shifts #985

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8f22fc9
session: add ShiftState method to session Store
ellemouton Feb 25, 2025
1ed4907
session: replace RevokeSession with ShiftState
ellemouton Feb 25, 2025
3272dda
session_rpcserver: use the Expired state for expired sessions
ellemouton Feb 25, 2025
ec8d136
docs: add release notes
ellemouton Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion session_rpcserver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ func (s *sessionRpcServer) resumeSession(ctx context.Context,
log.Debugf("Not resuming session %x with expiry %s",
pubKeyBytes, sess.Expiry)

err := s.cfg.db.ShiftState(sess.ID, session.StateRevoked)
err := s.cfg.db.ShiftState(sess.ID, session.StateExpired)
Copy link
Contributor

@bitromortac bitromortac Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

if err != nil {
return fmt.Errorf("error revoking session: %v", err)
}
Expand Down