multi: update LiT and all deps to use LND 0.19 #998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
force-pushed
the
lnd-19
branch
3 times, most recently
from
8d43d9a to
b1376e6
Compare
|
We need lightninglabs/taproot-assets#1454 to be able to bump to |
guggero
force-pushed
the
lnd-19
branch
3 times, most recently
from
9357baa to
ff84842
Compare
This commit updates: - LND - pool - loop - taproot-assets - faraday - lighting-node-connect - aperture - lndclient - btclog We start using the new btclog v2 library and the associated breaking changes in the lnd/build package. With this commit, we deprecate the `--remote.lit-maxlogfiles` and `--remote.lit-maxlogfilesize` options and introduce new logging options under the `--remote.lit-logging` namespace. Finally, the LND update introduced a new `MaxBlocksMinedPerTest` variable in the `lntest` package that we now need to override in order for our itests to pass.
For convenient flake hunting.
So that we use static fees in tests. This update is required with the latest LND update because of [this](lightningnetwork/lnd@b89387a) diff.
The accounts test in integrated mode is run twice so that we can test it against both the LND port and LiT port. So ensure that this is tested.
The itest-only goal is really useful for not needing to run the app build. But when switching between lnd versions, it's annoying if the lnd binary isn't built with itest-only. So we change that and always also build the btcd/lnd binaries with itest-only. This will take slightly longer but lead to fewer issues when switching branches between different lnd major versions.
With lnd 0.19 a lot of sweeper and timing related issues were fixed with the whole blockbeat synchronization. This also changes a couple of assumptions around when a block needs to be mined, so we need to adjust our itests to that.
guggero
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.