[WIP] switch from SatPerVbyte to SatPerKw fields in APIs #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SatPerByte is deprecated.
Include lightningnetwork/lnd#10067 add sats_per_kweight option when crafting a transaction (continue)
Use SatPerKw instead of SatPerVbyte in SendCoins, CloseChannel, and walletrpc.BumpFee APIs. Added new option WithSendCoinsFeerate for SendCoins and WithOpenChannelFeerate for OpenChannel API specifying feerate in sats/kw. Use new fields provided by lightningnetwork/lnd#10067
MPins
reviewed
Sep 5, 2025
| @@ -3164,6 +3181,9 @@ func MaxFeePerVbyte(maxFeePerVbyte chainfee.SatPerVByte) CloseChannelOption { | |||
| } | |||
| } | |||
|
|
|||
| // TODO: MaxFeePerKw | |||
| // See https://github.com/lightningnetwork/lnd/pull/10067/files#r2302906743 | |||
|
|
|||
There was a problem hiding this comment.
Just to let you know that I addressed the MaxFeePerKw in the lightningnetwork/lnd#10067
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is WIP! And only one commit is for review: "switch from SatPerVbyte to SatPerKw fields in APIs".
Depends on #240 , #239 , and lightningnetwork/lnd#10067
Use
SatPerKwinstead ofSatPerVbyteinSendCoins,CloseChannel, andwalletrpc.BumpFeeAPIs.Added new option
WithSendCoinsFeerateforSendCoinsandWithOpenChannelFeerateforOpenChannelAPI specifying feerate in sats/kw.Use new fields provided by lightningnetwork/lnd#10067
CC @MPins
Pull Request Checklist
in
lnd_services.goare updated.macaroon_recipes.goif your PR adds a new method that is calleddifferently than the RPC method it invokes.