-
Notifications
You must be signed in to change notification settings - Fork 122
WIP: go.mod: bump [email protected], taproot-assets, and lndclient versions #1045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @ffranr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates several core Go module dependencies to their latest versions, including significant bumps for Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request provides a set of beneficial dependency updates. Bumping lnd from a release candidate to v0.20.0-beta and updating taproot-assets to a newer release candidate are good maintenance steps. Most importantly, upgrading the Go version from 1.24.6 to 1.24.9 is a crucial security improvement, as it incorporates patches for several documented vulnerabilities. The dependency changes are consistent and correctly reflected in go.sum. This is a solid maintenance PR with no issues found.
8fb5670 to
84aafcc
Compare
84aafcc to
b8d6583
Compare
|
Previously I included this in the PR:
I’ve since removed it. This can be solved in litd instead, which fixes the issue for all components at once. |
90b49c7 to
b8d6583
Compare
Target Versions
[email protected][email protected][email protected]taproot-assets/[email protected]Remaining Steps
mainin tap