Skip to content

Conversation

@ffranr
Copy link
Contributor

@ffranr ffranr commented Nov 13, 2025

Target Versions

Remaining Steps

@gemini-code-assist
Copy link

Summary of Changes

Hello @ffranr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates several core Go module dependencies to their latest versions, including significant bumps for lnd, taproot-assets, and lndclient. These updates are crucial for incorporating the newest features, bug fixes, and improvements from these upstream projects. Additionally, the Go language version itself has been upgraded to ensure compatibility and leverage the latest language enhancements.

Highlights

  • Dependency Updates: The lnd dependency has been updated to v0.20.0-beta, taproot-assets to v0.7.0-rc2, and lndclient to v0.20.0-5.
  • Go Version Bump: The required Go language version has been updated from 1.24.6 to 1.24.9.
  • Minor Dependency Update: The lnd/fn/v2 module has been bumped from v2.0.8 to v2.0.9.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request provides a set of beneficial dependency updates. Bumping lnd from a release candidate to v0.20.0-beta and updating taproot-assets to a newer release candidate are good maintenance steps. Most importantly, upgrading the Go version from 1.24.6 to 1.24.9 is a crucial security improvement, as it incorporates patches for several documented vulnerabilities. The dependency changes are consistent and correctly reflected in go.sum. This is a solid maintenance PR with no issues found.

@ffranr ffranr changed the title go.mod: bump [email protected], taproot-assets, and lndclient versions WIP: go.mod: bump [email protected], taproot-assets, and lndclient versions Nov 13, 2025
@ffranr ffranr force-pushed the wip/bump-deps-lnd0.20.0 branch from 8fb5670 to 84aafcc Compare November 13, 2025 21:35
@ffranr ffranr changed the title WIP: go.mod: bump [email protected], taproot-assets, and lndclient versions go.mod: bump [email protected], taproot-assets, and lndclient versions Nov 13, 2025
@ffranr ffranr changed the title go.mod: bump [email protected], taproot-assets, and lndclient versions WIP: go.mod: bump [email protected], taproot-assets, and lndclient versions Nov 13, 2025
@ffranr ffranr force-pushed the wip/bump-deps-lnd0.20.0 branch from 84aafcc to b8d6583 Compare November 13, 2025 21:52
@ffranr
Copy link
Contributor Author

ffranr commented Nov 14, 2025

Previously I included this in the PR:

loopd: gate manager startup on chain notifier readiness
https://gist.github.com/ffranr/cedb3340e9f6bd880642cd6a8d685de1

I’ve since removed it. This can be solved in litd instead, which fixes the issue for all components at once.

@ffranr ffranr force-pushed the wip/bump-deps-lnd0.20.0 branch from 90b49c7 to b8d6583 Compare November 14, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant