loopout: trace logs for hasBandwidth mpp check #832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sputn1ck
approved these changes
Oct 14, 2024
bhandras
approved these changes
Oct 14, 2024
Member
bhandras
left a comment
bhandras
left a comment
There was a problem hiding this comment.
LGTM 🎉 Alternatively we could just log the local balances on startup and recreate the problematic case in a unit test.
hieblmi
force-pushed
the
log-loop-validation
branch
from
efdc4c6 to
f1e279f
Compare
Collaborator
Author
|
Added more logging. |
hieblmi
force-pushed
the
log-loop-validation
branch
2 times, most recently
from
e22ec28 to
caa8cc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds trace logs for the
hasBandwidthfunction that checks for mpp feasibility withinvalidateLoopOutRequest.