[8/8]StaticAddr: staging to master #848
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hieblmi
changed the title
We remove the static address client and add its rpcs into the SwapClient
Deposit schema extension with a withdrawal sweep address. If the user selects a deposit for withdrawal the destination address of the sweep is stored here.
A new rpc for deposit withdrawals is added. A withdrawal cooperatively spends the 2/2 musig deposit outpoint to a client-specified address.
A server endpoint to obtain a partial sig to cooperatively spend a 2/2 musig deposit outpoint.
This commit adds static address deposit outpoints to the QuoteRequest message. It allows to quote for loop in swaps with the total value of specified deposits.
This commit adds the number of deposits to the ServerLoopInQuoteRequest that the client wants to quote for.
rpcs for loop client and server are added to facilitate static address swap requests.
We add CRU procedures for static address swaps.
hieblmi
force-pushed
the
static-addr-staging
branch
from
44092a7 to
a7ff650
Compare
The static address state machine adds states to reflect the state of a deposit during a loop-in swap.
In this commit we introduce maximum fee percentages for the static loop-in htlc transactions. Since the server has the ability to publish htlc transactions without settling the swap payment we have to restrict the amount the server allocates for fees of these transactions.
In this commit we add the static address loop-in state machine and its orchestration through the manager.
hieblmi
force-pushed
the
static-addr-staging
branch
from
a7ff650 to
bbcfbfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we intent to merge the accumulated static address PRs 1-7 into master.