StaticAddr: withdrawal destination address and fee rate #859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sputn1ck
approved these changes
Nov 29, 2024
staticaddr/withdraw/manager.go
Outdated
| if err != nil { | ||
| return "", "", err | ||
|
|
||
| // Set withdrawal address to the provided one, or generate the it |
Member
There was a problem hiding this comment.
nit: this comment reads a bit weird
hieblmi
force-pushed
the
withdrawal-fee-and-address
branch
from
3d46154 to
fb9562b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a withdrawal could only be made to an internally generated address and conf target fee rate.
Now we can do
loop static withdraw --all --dest_addr XXX --sat_per_vbyte YYY