StaticAddr: fix rc review comments #868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starius
approved these changes
Dec 15, 2024
Collaborator
starius
left a comment
starius
left a comment
There was a problem hiding this comment.
LGTM! 🏒
Added a couple of comments.
staticaddr/withdraw/manager.go
Outdated
|
|
||
| if outputValue < int64(dustLimit) { | ||
| return nil, fmt.Errorf("withdrawal output value %v sats "+ | ||
| "below dust limit %v sats", outputValue, dustLimit) |
Collaborator
There was a problem hiding this comment.
%v prints amouts in BTC with " BTC" suffix. So this error message would look like "below dust limit 0.00000294 BTC sats".
I propose to use "%d sats" in both cases.
| ).FeePerKWeight() | ||
| } | ||
|
|
||
| // We'll now check the selected fee rate leaves a withdrawal output that |
Collaborator
There was a problem hiding this comment.
I propose to cover the logic and various sub-cases in this method with unit tests. Maybe factor out a pure function to make it unit tests friendly.
sputn1ck
approved these changes
Dec 16, 2024
hieblmi
force-pushed
the
fix-rc-review-comments
branch
from
ea871e9 to
acea303
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gather PR to fix upcoming rc testing issues.
--experimentalflag for static addresses