build+loop: add the commit hash to GetInfoResponse and change version semantics
#914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
ellemouton
reviewed
Apr 4, 2025
Makefile
Outdated
| GOMOD := GO111MODULE=on go mod | ||
|
|
||
| COMMIT := $(shell git describe --abbrev=40 --dirty) | ||
| COMMIT := $(shell git describe --abbrev=40 --dirty --tags --long) |
Member
There was a problem hiding this comment.
another option could be to add a separate COMMIT_HASH and then set that separately to the COMMIT one.
but that of course would result in needing a new global variable & then a new commit_hash rpc field in GetInfo.
So I guess we just need to decide if we want to keep the COMMIT working as it does today where if the "pure" tagged version is being run, then no commit hash is included in this variable.
But if it doesnt matter, then this is probs the easiest solution.
wdyt?
bhandras
force-pushed
the
ldflags-extended-commit
branch
2 times, most recently
from
989f163 to
055712b
Compare
bhandras
changed the title
GetInfoResponse and change version semantics
bhandras
force-pushed
the
ldflags-extended-commit
branch
from
055712b to
a0dd983
Compare
sputn1ck
approved these changes
Apr 4, 2025
Member
sputn1ck
left a comment
sputn1ck
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the change!
bhandras
force-pushed
the
ldflags-extended-commit
branch
2 times, most recently
from
6d3b3c4 to
cbb74f4
Compare
With this commit we extend GetinfoResponse with the strict commit hash (which also includes whether the build tree was clean or dirty).
bhandras
force-pushed
the
ldflags-extended-commit
branch
from
cbb74f4 to
9a6266f
Compare
ellemouton
approved these changes
Apr 4, 2025
| GOMOD := GO111MODULE=on go mod | ||
|
|
||
| COMMIT := $(shell git describe --abbrev=40 --dirty) | ||
| COMMIT := $(shell git describe --abbrev=40 --dirty | sed -E 's/.*-g([0-9a-f]{40})(-dirty)?/\1\2/') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we extend
GetinfoResponsewith the strict commit hash (which also includes whether the build tree was clean or dirty).