Skip to content

Conversation

@starius
Copy link
Collaborator

@starius starius commented Apr 4, 2025

Don't copy values of ID column from sweeps to sweeps2 and let it auto-assign values there. This is needed for the sequencer for that column to be up-to-date with the values.

I manually tested the migration in sqlite3 and postgres.

Pull Request Checklist

  • Update release_notes.md if your PR contains major features, breaking changes or bugfixes

Don't copy values of ID column from sweeps to sweeps2 and let it auto-assign
values there. This is needed for the sequencer for that column to be up-to-date
with the values.
Copy link
Member

@sputn1ck sputn1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for the fix 🥇

@starius starius marked this pull request as ready for review April 4, 2025 20:35
@starius starius merged commit 91ff83a into lightninglabs:master Apr 4, 2025
4 checks passed
@starius starius deleted the fix-migration-13 branch April 4, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants