sweepbatcher: fix height hint for confirmations #917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we passed the current best block height as the height hint to RegisterConfirmationsNtfn. If Loop was shut down when a sweep was confirmed and restarted later, it would use the current best height as the hint. This caused the confirmation to be missed, since it had already occurred before that height. This commit fixes the issue by passing the initiation height of the swap as the height hint instead. This is consistent with what we do in other places where we use RegisterConfirmationsNtfn. Since LND caches previously passed height hints for RegisterConfirmationsNtfn and uses maximum passed value, to actually recover in such a condition, one has to restart LND passing the option --height-hint-cache-query-disable and then restart Loop applying this fix. If a pruned bitcoind backend is used, this might not work.
starius
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we passed the current best block height as the height hint to
RegisterConfirmationsNtfn. If Loop was shut down when a sweep was confirmed and restarted later, it would use the current best height as the hint. This caused the confirmation to be missed, since it had already occurred before that height.This commit fixes the issue by passing the initiation height of the swap as the height hint instead. This is consistent with what we do in other places where we use
RegisterConfirmationsNtfn.Since LND caches previously passed height hints for RegisterConfirmationsNtfn and uses maximum passed value, to actually recover in such a condition, one has to restart LND passing the option
--height-hint-cache-query-disableand then restart Loop applying this fix. If a pruned bitcoind backend is used, this might not work.Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes